( )⚙ D3089 convert: use repo.lookup() for converting to nodeid

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3089

convert: use repo.lookup() for converting to nodeid
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe45545f7895e: convert: use repo.lookup() for converting to nodeid
Summary

This is a list of revs that come from the CLI (opts['rev']). Perhaps
we should allow any revset, but I'll leave that for someone else to
improve if they care.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
Closed by commit rHGe45545f7895e: convert: use repo.lookup() for converting to nodeid (authored by martinvonz). · Explain WhyApr 5 2018, 9:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/convert/hg.py (2 lines)

Diff 7720

hgext/convert/hg.py

startrev = self.repo.changelog.rev(startnode) startrev = self.repo.changelog.rev(startnode)
children = {startnode: 1} children = {startnode: 1}
for r in self.repo.changelog.descendants([startrev]): for r in self.repo.changelog.descendants([startrev]):
children[self.repo.changelog.node(r)] = 1 children[self.repo.changelog.node(r)] = 1
self.keep = children.__contains__ self.keep = children.__contains__
else: else:
self.keep = util.always self.keep = util.always
if revs: if revs:
self._heads = [self.repo[r].node() for r in revs] self._heads = [self.repo.lookup(r) for r in revs]
else: else:
self._heads = self.repo.heads() self._heads = self.repo.heads()
else: else:
if revs or startnode is not None: if revs or startnode is not None:
raise error.Abort(_('hg.revs cannot be combined with ' raise error.Abort(_('hg.revs cannot be combined with '
'hg.startrev or --rev')) 'hg.startrev or --rev'))
nodes = set() nodes = set()
parents = set() parents = set()