This is an archive of the discontinued Mercurial Phabricator instance.

peer: remove non iterating batcher (API)
ClosedPublic

Authored by indygreg on Aug 10 2017, 2:47 AM.

Details

Summary

The last use of this API was removed in b6e71f8af5b8 in 2016. While
not formally deprecated, as of the last commit the code is no longer
explicitly tested. I think the new API has existed long enough for
people to transition to it.

I also have plans to more formalize the peer API and removing batch()
makes that work easier.

I'm not convinced the current client-side API around batching is
great. But it's the best we have at the moment.

.. api:: remove peer.batch()

Replace with peer.iterbatch().

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped