This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3289

streamclone: use command executor for wire protocol commands
ClosedPublic

Authored by indygreg on Apr 12 2018, 3:59 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG65b86ee69383: streamclone: use command executor for wire protocol commands
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 12 2018, 3:59 PM
indygreg updated this revision to Diff 8128.Apr 13 2018, 3:14 PM
durin42 accepted this revision.Apr 13 2018, 5:48 PM
This revision is now accepted and ready to land.Apr 13 2018, 5:48 PM
Closed by commit rHG65b86ee69383: streamclone: use command executor for wire protocol commands (authored by indygreg). · Explain WhyApr 13 2018, 6:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/streamclone.py (11 lines)

Diff 8174

mercurial/streamclone.py

repo = pullop.repo repo = pullop.repo
remote = pullop.remote remote = pullop.remote
# Save remote branchmap. We will use it later to speed up branchcache # Save remote branchmap. We will use it later to speed up branchcache
# creation. # creation.
rbranchmap = None rbranchmap = None
if remote.capable('branchmap'): if remote.capable('branchmap'):
rbranchmap = remote.branchmap() with remote.commandexecutor() as e:
rbranchmap = e.callcommand('branchmap', {}).result()
repo.ui.status(_('streaming all changes\n')) repo.ui.status(_('streaming all changes\n'))
fp = remote.stream_out() with remote.commandexecutor() as e:
fp = e.callcommand('stream_out', {}).result()
# TODO strictly speaking, this code should all be inside the context
# manager because the context manager is supposed to ensure all wire state
# is flushed when exiting. But the legacy peers don't do this, so it
# doesn't matter.
l = fp.readline() l = fp.readline()
try: try:
resp = int(l) resp = int(l)
except ValueError: except ValueError:
raise error.ResponseError( raise error.ResponseError(
_('unexpected response from remote server:'), l) _('unexpected response from remote server:'), l)
if resp == 1: if resp == 1:
raise error.Abort(_('operation forbidden by server')) raise error.Abort(_('operation forbidden by server'))