This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3318

repository: remove ipeercommands from ipeerbase
ClosedPublic

Authored by indygreg on Apr 13 2018, 3:14 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG62ebfda864de: repository: remove ipeercommands from ipeerbase
Summary

AFAICT all callers in core have moved to the commandexecutor
interface for invoking wire protocol commands. Or at least they
aren't using the named methods on ipeercommands to invoke them.

This means we can drop ipeercommands from the ipeerbase interface.
As far as interface based programming goes, it is now illegal to call
an ipeercommands method for issuing wire protocol commands. However,
the methods are still there, so they will still work. At some
point we will want to break that API...

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 13 2018, 3:14 PM
durin42 added a subscriber: durin42.Apr 13 2018, 6:00 PM

I think we should probably avoid breaking that API until after we get remotefilelog in core? That'd at least be nice for me, because RFL is pretty invasive proto-wise. :(

durin42 accepted this revision.Apr 13 2018, 6:06 PM
This revision is now accepted and ready to land.Apr 13 2018, 6:06 PM
indygreg added a comment.Apr 13 2018, 6:06 PM
In D3318#53227, @durin42 wrote:

I think we should probably avoid breaking that API until after we get remotefilelog in core? That'd at least be nice for me, because RFL is pretty invasive proto-wise. :(

I have little desire to purge this until at least next release. Minimal gains from it. Wins come from core and new peers being able to use new API.

Closed by commit rHG62ebfda864de: repository: remove ipeercommands from ipeerbase (authored by indygreg). · Explain WhyApr 13 2018, 6:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8138

mercurial/localrepo.py

return f return f
def sendcommands(self): def sendcommands(self):
self._sent = True self._sent = True
def close(self): def close(self):
self._closed = True self._closed = True
@zi.implementer(repository.ipeercommands)
class localpeer(repository.peer): class localpeer(repository.peer):
'''peer for a local repo; reflects only the most recent API''' '''peer for a local repo; reflects only the most recent API'''
def __init__(self, repo, caps=None): def __init__(self, repo, caps=None):
super(localpeer, self).__init__() super(localpeer, self).__init__()
if caps is None: if caps is None:
caps = moderncaps.copy() caps = moderncaps.copy()

mercurial/repository.py

a single HTTP request. While some peers may support multiple command a single HTTP request. While some peers may support multiple command
sends over the wire per executor, consumers need to code to the least sends over the wire per executor, consumers need to code to the least
capable peer. So it should be assumed that command executors buffer capable peer. So it should be assumed that command executors buffer
called commands until they are told to send them and that each called commands until they are told to send them and that each
command executor could result in a new connection or wire-level request command executor could result in a new connection or wire-level request
being issued. being issued.
""" """
class ipeerbase(ipeerconnection, ipeercapabilities, ipeercommands, class ipeerbase(ipeerconnection, ipeercapabilities, ipeerrequests):
ipeerrequests):
"""Unified interface for peer repositories. """Unified interface for peer repositories.
All peer instances must conform to this interface. All peer instances must conform to this interface.
""" """
@zi.implementer(ipeerbase) @zi.implementer(ipeerbase)
class peer(object): class peer(object):
"""Base class for peer repositories.""" """Base class for peer repositories."""

mercurial/wireprotov1peer.py

# And ask the coroutine to decode that value. # And ask the coroutine to decode that value.
try: try:
result = next(batchable) result = next(batchable)
except Exception: except Exception:
f.set_exception_info(*sys.exc_info()[1:]) f.set_exception_info(*sys.exc_info()[1:])
else: else:
f.set_result(result) f.set_result(result)
@zi.implementer(repository.ipeerlegacycommands) @zi.implementer(repository.ipeercommands, repository.ipeerlegacycommands)
class wirepeer(repository.peer): class wirepeer(repository.peer):
"""Client-side interface for communicating with a peer repository. """Client-side interface for communicating with a peer repository.
Methods commonly call wire protocol commands of the same name. Methods commonly call wire protocol commands of the same name.
See also httppeer.py and sshpeer.py for protocol-specific See also httppeer.py and sshpeer.py for protocol-specific
implementations of this interface. implementations of this interface.
""" """