This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3333

wireprotoframing: use value passed into function
ClosedPublic

Authored by indygreg on Apr 13 2018, 5:36 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGb9502b5f2066: wireprotoframing: use value passed into function
Summary

Oops.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 13 2018, 5:36 PM
durin42 accepted this revision.Apr 13 2018, 6:07 PM
This revision is now accepted and ready to land.Apr 13 2018, 6:07 PM
Closed by commit rHGb9502b5f2066: wireprotoframing: use value passed into function (authored by indygreg). · Explain WhyApr 13 2018, 6:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotoframing.py (2 lines)

Diff 8156

mercurial/wireprotoframing.py

flags=0, flags=0,
payload=payload) payload=payload)
class stream(object): class stream(object):
"""Represents a logical unidirectional series of frames.""" """Represents a logical unidirectional series of frames."""
def __init__(self, streamid, active=False): def __init__(self, streamid, active=False):
self.streamid = streamid self.streamid = streamid
self._active = False self._active = active
def makeframe(self, requestid, typeid, flags, payload): def makeframe(self, requestid, typeid, flags, payload):
"""Create a frame to be sent out over this stream. """Create a frame to be sent out over this stream.
Only returns the frame instance. Does not actually send it. Only returns the frame instance. Does not actually send it.
""" """
streamflags = 0 streamflags = 0
if not self._active: if not self._active: