This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: use new peer interface
ClosedPublic

Authored by indygreg on Aug 11 2017, 12:20 AM.

Details

Summary

The wirepeer class provides concrete implementations of peer interface
methods for calling wire protocol commands. It makes sense for this
class to inherit from the peer abstract base class. So we change
that.

Since httppeer and sshpeer have already been converted to the new
interface, peerrepository is no longer adding any value. So it has
been removed. httppeer and sshpeer have been updated to reflect the
loss of peerrepository and the inheritance of the abstract base
class in wirepeer.

The code changes in wirepeer are reordering of methods to group
by interface.

Some Python code in tests was updated to reflect changed APIs.

.. api::

peer.peerrepository has been removed. Use repository.peer abstract
base class to represent a peer repository.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 11 2017, 12:20 AM
durin42 accepted this revision.Aug 11 2017, 2:32 PM
This revision is now accepted and ready to land.Aug 11 2017, 2:32 PM
This revision was automatically updated to reflect the committed changes.