This is an archive of the discontinued Mercurial Phabricator instance.

Differential D359

pushvars: add a coreconfigitem for push.pushvars.server
ClosedPublic

Authored by pulkit on Aug 11 2017, 7:26 PM.

Details

Reviewers
lothiraldan
Group Reviewers
hg-reviewers
Commits
rHG057d31ceace3: pushvars: add a coreconfigitem for push.pushvars.server
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Aug 11 2017, 7:26 PM
lothiraldan accepted this revision.Aug 14 2017, 4:31 AM
lothiraldan added a subscriber: lothiraldan.

LGTM

Closed by commit rHG057d31ceace3: pushvars: add a coreconfigitem for push.pushvars.server (authored by pulkit). · Explain WhyAug 15 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (2 lines)
Mmercurial/configitems.py (3 lines)

Diff 963

mercurial/bundle2.py

cache.write() cache.write()
op.ui.debug('applied %i hgtags fnodes cache entries\n' % count) op.ui.debug('applied %i hgtags fnodes cache entries\n' % count)
@parthandler('pushvars') @parthandler('pushvars')
def bundle2getvars(op, part): def bundle2getvars(op, part):
'''unbundle a bundle2 containing shellvars on the server''' '''unbundle a bundle2 containing shellvars on the server'''
# An option to disable unbundling on server-side for security reasons # An option to disable unbundling on server-side for security reasons
if op.ui.configbool('push', 'pushvars.server', False): if op.ui.configbool('push', 'pushvars.server'):
hookargs = {} hookargs = {}
for key, value in part.advisoryparams: for key, value in part.advisoryparams:
key = key.upper() key = key.upper()
# We want pushed variables to have USERVAR_ prepended so we know # We want pushed variables to have USERVAR_ prepended so we know
# they came from the --pushvar flag. # they came from the --pushvar flag.
key = "USERVAR_" + key key = "USERVAR_" + key
hookargs[key] = value hookargs[key] = value
op.addhookargs(hookargs) op.addhookargs(hookargs)

mercurial/configitems.py

default=2, default=2,
) )
coreconfigitem('progress', 'refresh', coreconfigitem('progress', 'refresh',
default=0.1, default=0.1,
) )
coreconfigitem('progress', 'width', coreconfigitem('progress', 'width',
default=dynamicdefault, default=dynamicdefault,
) )
coreconfigitem('push', 'pushvars.server',
default=False,
)
coreconfigitem('server', 'bundle1', coreconfigitem('server', 'bundle1',
default=True, default=True,
) )
coreconfigitem('server', 'bundle1gd', coreconfigitem('server', 'bundle1gd',
default=None, default=None,
) )
coreconfigitem('server', 'compressionengines', coreconfigitem('server', 'compressionengines',
default=list, default=list,