This is an archive of the discontinued Mercurial Phabricator instance.

resolve: graduate resolve.mark-check from experimental, add docs
ClosedPublic

Authored by spectral on Aug 3 2018, 4:56 PM.

Details

Summary

Since this hasn't been in a release yet, I'm not bothering to add an alias for
the experimental name of the config variable.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Aug 3 2018, 4:56 PM
pulkit added a subscriber: pulkit.Aug 3 2018, 5:24 PM
pulkit added inline comments.
mercurial/help/config.txt
452

I think here you mean 'none'?

spectral added inline comments.Aug 3 2018, 5:29 PM
mercurial/help/config.txt
452

No, I didn't document the `none` case explicitly. This is saying that "even if it's going to abort, adding --all will bypass the error" (this is part of the hint when it aborts, so maybe it's not useful to mention here?)

Should I remove this last sentence?

pulkit added inline comments.Aug 3 2018, 5:35 PM
mercurial/help/config.txt
452

Maybe rephrase to something like that if --all flag is passed, only warning will be shown and error won't be raised.
(I am not good at english, so feel free to decide how it is better and let me know, I will push then.)

spectral updated this revision to Diff 9866.Aug 3 2018, 6:47 PM
spectral marked an inline comment as done.Aug 3 2018, 6:48 PM
spectral added inline comments.
mercurial/help/config.txt
452

Please take another look.

pulkit accepted this revision.Aug 4 2018, 1:04 PM
pulkit added inline comments.
mercurial/configitems.py
937

Moved this up in order to maintain alphabetical order.

mercurial/help/config.txt
452

Fixed -all to --all in flight.

spectral marked an inline comment as done.Aug 4 2018, 1:13 PM
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
mercurial/configitems.py
197

Unrelated to this patch, but should the default be 'none` as the documentation says? It also looks like the code doesn't handle that value.

spectral marked an inline comment as done.Aug 5 2018, 4:20 AM
spectral added inline comments.
mercurial/configitems.py
197

D4121, good catch.