This is an archive of the discontinued Mercurial Phabricator instance.

tests: avoid unnecessarily looking inside .hg/ in test-narrow*
ClosedPublic

Authored by martinvonz on Aug 3 2018, 5:23 PM.

Details

Summary

Many of the narrow tests were looking at .hg/narrowspec. I think most
of them were written before we added hg tracked, but now that we
have that command, we should fix the tests. There were also a few
instances of tests looking at .hg/dirstate. I fixed those to use `hg
files` instead.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Aug 3 2018, 5:23 PM
pulkit added a subscriber: pulkit.Aug 3 2018, 5:29 PM

The commit message says you used hg debugdirstate but looking at changes, you used hg files. I think the commit message needs to be updated.

tests/test-narrow-expanddirstate.t
32

This should be hg files.

In D4093#63407, @pulkit wrote:

The commit message says you used hg debugdirstate but looking at changes, you used hg files. I think the commit message needs to be updated.

Oops, good catch. Will fix.

martinvonz edited the summary of this revision. (Show Details)Aug 3 2018, 5:31 PM
pulkit added inline comments.Aug 3 2018, 5:37 PM
tests/test-narrow-expanddirstate.t
32

Looks like you missed this comment.

martinvonz marked 2 inline comments as done.Aug 3 2018, 5:47 PM
martinvonz added inline comments.
tests/test-narrow-expanddirstate.t
32

Yes, I didn't notice that. Sorry about that, and thanks for careful review.

martinvonz marked an inline comment as done.Aug 3 2018, 5:47 PM
martinvonz updated this revision to Diff 9862.
pulkit accepted this revision.Aug 3 2018, 5:50 PM
This revision was automatically updated to reflect the committed changes.