This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: factor changelogdone into an argument
ClosedPublic

Authored by indygreg on Aug 6 2018, 3:51 PM.

Details

Summary

The variable was basically tracking whether the current operation
is being performed against the changelog or something else. So
let's just pass such a flag to everything that needs to access it.

I'm still not a huge fan of building changelog awareness into
low-level functions like revision delta generation. But passing
an argument is strictly better than state on the packer instance.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Aug 6 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.