( )⚙ D4197 changegroup: invert conditional and dedent

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4197

changegroup: invert conditional and dedent
ClosedPublic

Authored by indygreg on Aug 9 2018, 2:51 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd56a6b78de3b: changegroup: invert conditional and dedent
Summary

I don't like seeing code that visually resembles the pyramid of
doom.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 9 2018, 2:51 PM
Closed by commit rHGd56a6b78de3b: changegroup: invert conditional and dedent (authored by indygreg). · Explain WhyAug 9 2018, 4:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (28 lines)

Diff 10186

mercurial/changegroup.py

return clnode return clnode
return lookupmflinknode return lookupmflinknode
size = 0 size = 0
while tmfnodes: while tmfnodes:
dir, nodes = tmfnodes.popitem() dir, nodes = tmfnodes.popitem()
store = dirlog(dir) store = dirlog(dir)
prunednodes = self._prune(store, nodes, commonrevs) prunednodes = self._prune(store, nodes, commonrevs)
if not dir or prunednodes:
if dir and not prunednodes:
continue
lookupfn = makelookupmflinknode(dir, nodes) lookupfn = makelookupmflinknode(dir, nodes)
if self._ellipses: if self._ellipses:
revs = _sortnodesellipsis(store, prunednodes, cl, revs = _sortnodesellipsis(store, prunednodes, cl,
lookupfn) lookupfn)
else: else:
revs = _sortnodesnormal(store, prunednodes, revs = _sortnodesnormal(store, prunednodes,
self._reorder) self._reorder)
for x in self._packmanifests(dir, store, revs, lookupfn, for x in self._packmanifests(dir, store, revs, lookupfn,
clrevtolocalrev): clrevtolocalrev):
size += len(x) size += len(x)
yield x yield x
self._verbosenote(_('%8.i (manifests)\n') % size) self._verbosenote(_('%8.i (manifests)\n') % size)
yield self._manifestsend yield self._manifestsend
# The 'source' parameter is useful for extensions # The 'source' parameter is useful for extensions
def generatefiles(self, changedfiles, commonrevs, source, def generatefiles(self, changedfiles, commonrevs, source,
mfdicts, fastpathlinkrev, fnodes, clrevs): mfdicts, fastpathlinkrev, fnodes, clrevs):
changedfiles = list(filter(self._filematcher, changedfiles)) changedfiles = list(filter(self._filematcher, changedfiles))