( )⚙ D4270 changegroup: clean up changelog callback

This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: clean up changelog callback
ClosedPublic

Authored by indygreg on Aug 13 2018, 12:55 PM.

Details

Summary

changelog.read() calls changelog.changelogrevion() then turns it into
a tuple. Let's call changelogrevision() directly and used named
attributes to make code easier to read.

While we're here, also change some variable names to make code easier
to read.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 13 2018, 12:55 PM
This revision was automatically updated to reflect the committed changes.