( )⚙ D4274 manifest: remove addgroup() from manifestlog and imanifestlog

This is an archive of the discontinued Mercurial Phabricator instance.

manifest: remove addgroup() from manifestlog and imanifestlog
ClosedPublic

Authored by indygreg on Aug 13 2018, 12:55 PM.

Details

Summary

addgroup() is part of the storage interface for manifests.
Unfortunately, we don't yet have a formal storage interface
for manifests. (One will be established in subsequent commits.)

One thing is for sure, addgroup() doesn't belong on imanifestlog -
at least not unless we extend that interface to encompass storage.

For now, let's access addgroup() on the _revlog attribute, just like
we do for tree manifests. Even though this violates visibility,
it is consistent.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.