Page MenuHomePhabricator

remotefilelogserver: use modern pattern for registering commands
ClosedPublic

Authored by durin42 on Sep 13 2018, 11:02 AM.

Details

Summary

This fixes some server-side problems on 4.7 caused by the (reasonable)
default of requiring push permissions on unknown commands.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 13 2018, 11:02 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2018, 11:02 AM
indygreg added inline comments.
remotefilelog/remotefilelogserver.py
96

`permission` was added in 4.6 IIRC. So this won't work with older versions. I'm not sure if we care.

durin42 added a subscriber: quark.Sep 13 2018, 3:24 PM
durin42 added inline comments.
remotefilelog/remotefilelogserver.py
96

@quark do we care? I mean, I know we at Google don't care, and I imagine y'all dont' care about anything before 4.7 either...

quark accepted this revision.Sep 13 2018, 3:32 PM
This revision is now accepted and ready to land.Sep 13 2018, 3:32 PM
quark added a comment.Sep 13 2018, 3:36 PM

No, hg-experimental didn't care about compatibility with older Mercurial. Otherwise the code would be a mess.

This revision was automatically updated to reflect the committed changes.