This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4560

remotefilelogserver: use modern pattern for registering commands
ClosedPublic

Authored by durin42 on Sep 13 2018, 11:02 AM.

Download Raw Diff

Details

Reviewers

quark

Group Reviewers

Restricted Project

Commits

rFBHGX560cf19e4973: remotefilelogserver: use modern pattern for registering commands

Summary

This fixes some server-side problems on 4.7 caused by the (reasonable)
default of requiring push permissions on unknown commands.

Diff Detail

Repository

rFBHGX Facebook Mercurial Extensions

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

durin42 created this revision.Sep 13 2018, 11:02 AM

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2018, 11:02 AM

durin42 added a child revision: D4561: tests: accept new hg output about local changesets being published.Sep 13 2018, 11:02 AM

indygreg added a subscriber: indygreg.Sep 13 2018, 3:22 PM

indygreg added inline comments.

remotefilelog/remotefilelogserver.py
96	`permission` was added in 4.6 IIRC. So this won't work with older versions. I'm not sure if we care.

durin42 added a subscriber: quark.Sep 13 2018, 3:24 PM

durin42 added inline comments.

remotefilelog/remotefilelogserver.py
96	@quark do we care? I mean, I know we at Google don't care, and I imagine y'all dont' care about anything before 4.7 either...

quark accepted this revision.Sep 13 2018, 3:32 PM

This revision is now accepted and ready to land.Sep 13 2018, 3:32 PM

No, hg-experimental didn't care about compatibility with older Mercurial. Otherwise the code would be a mess.

Closed by commit rFBHGX560cf19e4973: remotefilelogserver: use modern pattern for registering commands (authored by durin42). · Explain WhySep 13 2018, 4:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			remotefilelog/remotefilelogserver.py (21 lines)

Commit	Parents	Author	Summary	Date
		Augie Fackler		Sep 12 2018, 8:05 PM

Status	Author	Revision
Closed	durin42	D4583 shallowbundle: dump this revision prefetching logic
Closed	durin42	D4581 remotefilelog: update for core changegroup packing changes
Closed	durin42	D4580 shallowrepo: use correct api to get manifestlog storage if available
Closed	durin42	D4579 basestore: stop looking at the Nth item of an N-length revlog
Closed	durin42	D4578 remotefilelogserver: allow signature of generatefiles() to change
Closed	durin42	D4577 remotefilelogserver: adapt for there being only one cgpacker
Closed	durin42	D4561 tests: accept new hg output about local changesets being published
Closed	durin42	D4560 remotefilelogserver: use modern pattern for registering commands
Closed	durin42	D4559 cleanup: only look for the capabilities we care about in tests
Closed	durin42	D4558 tests: update remotefilelog http test to require two fetches

Diff 10992

remotefilelog/remotefilelogserver.py

	def onetimesetup(ui):			def onetimesetup(ui):
	"""Configures the wireprotocol for both clients and servers.			"""Configures the wireprotocol for both clients and servers.
	"""			"""
	global onetime			global onetime
	if onetime:			if onetime:
	return			return
	onetime = True			onetime = True

				if util.safehasattr(wireprotov1server, 'wireprotocommand'):
				# support file content requests
				wireprotov1server.wireprotocommand(
				'getflogheads', 'path', permission='pull')(getflogheads)
				indygregUnsubmitted Not Done `permission` was added in 4.6 IIRC. So this won't work with older versions. I'm not sure if we care. indygreg: ``permission`` was added in 4.6 IIRC. So this won't work with older versions. I'm not sure if…
				durin42AuthorUnsubmitted Not Done @quark do we care? I mean, I know we at Google don't care, and I imagine y'all dont' care about anything before 4.7 either... durin42: @quark do we care? I mean, I know we at Google don't care, and I imagine y'all dont' care about…
				wireprotov1server.wireprotocommand(
				'getfiles', '', permission='pull')(getfiles)
				wireprotov1server.wireprotocommand(
				'getfile', 'file node', permission='pull')(getfile)
				wireprotov1server.wireprotocommand(
				'getpackv1', '*', permission='pull')(getpack)
				else:
	# support file content requests			# support file content requests
	wireprotov1server.commands['getflogheads'] = (getflogheads, 'path')			wireprotov1server.commands['getflogheads'] = (getflogheads, 'path')
	wireprotov1server.commands['getfiles'] = (getfiles, '')			wireprotov1server.commands['getfiles'] = (getfiles, '')
	wireprotov1server.commands['getfile'] = (getfile, 'file node')			wireprotov1server.commands['getfile'] = (getfile, 'file node')
	wireprotov1server.commands['getpackv1'] = (getpack, '*')			wireprotov1server.commands['getpackv1'] = (getpack, '*')

	class streamstate(object):			class streamstate(object):
	match = None			match = None
	shallowremote = False			shallowremote = False
	noflatmf = False			noflatmf = False
	state = streamstate()			state = streamstate()

	def stream_out_shallow(repo, proto, other):			def stream_out_shallow(repo, proto, other):

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	10992		Sep 13 2018, 11:02 AM	★	★
Diff 2	11024	rFBHGX560cf19e497315b5315829529dabca4787265b9c	Sep 12 2018, 8:05 PM	★	★