This is an archive of the discontinued Mercurial Phabricator instance.

narrow: remove custom filelog type
ClosedPublic

Authored by indygreg on Sep 18 2018, 6:40 PM.

Details

Summary

This functionality is now handled by core as of the previous commit.

I wanted this to be a standalone commit because the deleted code
makes a reference to remotefilelog's file type missing a node() method
and this may have implications to narrow+remotefilelog usage. The code
in core doesn't perform this check and therefore behavior may be subtly
different and buggy.

But I /think/ the check is merely a performance optimization and
nothing more. So I'm optimistic this will continue to "just work."

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 18 2018, 6:40 PM
This revision was automatically updated to reflect the committed changes.