This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4649

narrow: remove narrowrevlog
ClosedPublic

Authored by indygreg on Sep 18 2018, 6:40 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGa063786c89fb: narrow: remove narrowrevlog
Summary

Core now automatically enables ellipsis support on revlogs when
repositories have narrow enabled. So, we no longer need to globally
register the revlog flag as part of activating the narrow extension
and this code can be deleted.

A side effect of this change is that repositories will now raise an
error on encountering an ellipsis flag when the narrow extension is
loaded. Previously, loading the narrow extension on a non-narrow repo
could result in silent usage of the ellipsis flag. This could lead
to undetected bugs. I think the new behavior is more correct.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 18 2018, 6:40 PM
Closed by commit rHGa063786c89fb: narrow: remove narrowrevlog (authored by indygreg). · Explain WhySep 23 2018, 5:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11275

hgext/narrow/TODO.rst

Integration with the share extension needs improvement. Right now Integration with the share extension needs improvement. Right now
we've seen some odd bugs, and the way we modify the contents of the we've seen some odd bugs, and the way we modify the contents of the
.hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec(). .hg/shared file is unfortunate. See wrappostshare() and unsharenarrowspec().
Resolve commentary on narrowrepo.wraprepo.narrowrepository.status Resolve commentary on narrowrepo.wraprepo.narrowrepository.status
about the filtering of status being done at an awkward layer. This about the filtering of status being done at an awkward layer. This
came up the import to hgext, but nobody's got concrete improvement came up the import to hgext, but nobody's got concrete improvement
ideas as of then. ideas as of then.
Fold most (or preferably all) of narrowrevlog.py into core. Address commentary in manifest.excludedmanifestrevlog.add -
Address commentary in narrowrevlog.excludedmanifestrevlog.add -
specifically we should improve the collaboration with core so that specifically we should improve the collaboration with core so that
add() never gets called on an excluded directory and we can improve add() never gets called on an excluded directory and we can improve
the stand-in to raise a ProgrammingError. the stand-in to raise a ProgrammingError.
Figure out how to correctly produce narrowmanifestrevlog and
narrowfilelog instances instead of monkeypatching regular revlogs at
runtime to our subclass. Even better, merge the narrowing logic
directly into core.
Reason more completely about rename-filtering logic in Reason more completely about rename-filtering logic in
narrowfilelog. There could be some surprises lurking there. narrowfilelog. There could be some surprises lurking there.
Formally document the narrowspec format. Unify with sparse, if at all Formally document the narrowspec format. Unify with sparse, if at all
possible. For bonus points, unify with the server-specified narrowspec possible. For bonus points, unify with the server-specified narrowspec
format. format.
narrowrepo.setnarrowpats() or narrowspec.save() need to make sure narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
they're holding the wlock. they're holding the wlock.

hgext/narrow/__init__.py

) )
from . import ( from . import (
narrowbundle2, narrowbundle2,
narrowcommands, narrowcommands,
narrowcopies, narrowcopies,
narrowpatch, narrowpatch,
narrowrepo, narrowrepo,
narrowrevlog,
narrowtemplates, narrowtemplates,
narrowwirepeer, narrowwirepeer,
) )
configtable = {} configtable = {}
configitem = registrar.configitem(configtable) configitem = registrar.configitem(configtable)
# Narrowhg *has* support for serving ellipsis nodes (which are used at # Narrowhg *has* support for serving ellipsis nodes (which are used at
# least by Google's internal server), but that support is pretty # least by Google's internal server), but that support is pretty
cmdtable = narrowcommands.table cmdtable = narrowcommands.table
def featuresetup(ui, features): def featuresetup(ui, features):
features.add(repository.NARROW_REQUIREMENT) features.add(repository.NARROW_REQUIREMENT)
def uisetup(ui): def uisetup(ui):
"""Wraps user-facing mercurial commands with narrow-aware versions.""" """Wraps user-facing mercurial commands with narrow-aware versions."""
localrepo.featuresetupfuncs.add(featuresetup) localrepo.featuresetupfuncs.add(featuresetup)
narrowrevlog.setup()
narrowbundle2.setup() narrowbundle2.setup()
narrowcommands.setup() narrowcommands.setup()
narrowwirepeer.uisetup() narrowwirepeer.uisetup()
def reposetup(ui, repo): def reposetup(ui, repo):
"""Wraps local repositories with narrow repo support.""" """Wraps local repositories with narrow repo support."""
if not repo.local(): if not repo.local():
return return

hgext/narrow/narrowrevlog.py

  • This file was deleted.
# narrowrevlog.py - revlog storing irrelevant nodes as "ellipsis" nodes
#
# Copyright 2017 Google, Inc.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from mercurial import (
revlog,
)
revlog.addflagprocessor(revlog.REVIDX_ELLIPSIS, revlog.ellipsisprocessor)
def setup():
# We just wanted to add the flag processor, which is done at module
# load time.
pass
hgext/narrow/__init__.py