This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4645

revlog: define ellipsis flag processors in core
ClosedPublic

Authored by indygreg on Sep 18 2018, 6:40 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGdb088e133e91: revlog: define ellipsis flag processors in core
Summary

We will soon be teaching core to honor the ellipsis flag on revlogs.
Moving the definition of the processor functions to core is the first
step in this.

The processor is still not registered unless the narrow extension is
loaded.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 18 2018, 6:40 PM
Closed by commit rHGdb088e133e91: revlog: define ellipsis flag processors in core (authored by indygreg). · Explain WhySep 23 2018, 5:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowrevlog.py (12 lines)
Mmercurial/revlog.py (16 lines)

Diff 11271

hgext/narrow/narrowrevlog.py

# narrowrevlog.py - revlog storing irrelevant nodes as "ellipsis" nodes # narrowrevlog.py - revlog storing irrelevant nodes as "ellipsis" nodes
# #
# Copyright 2017 Google, Inc. # Copyright 2017 Google, Inc.
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
from mercurial import ( from mercurial import (
revlog, revlog,
) )
def readtransform(self, text): revlog.addflagprocessor(revlog.REVIDX_ELLIPSIS, revlog.ellipsisprocessor)
return text, False
def writetransform(self, text):
return text, False
def rawtransform(self, text):
return False
revlog.addflagprocessor(revlog.REVIDX_ELLIPSIS,
(readtransform, writetransform, rawtransform))
def setup(): def setup():
# We just wanted to add the flag processor, which is done at module # We just wanted to add the flag processor, which is done at module
# load time. # load time.
pass pass

mercurial/revlog.py

CensoredNodeError = error.CensoredNodeError CensoredNodeError = error.CensoredNodeError
ProgrammingError = error.ProgrammingError ProgrammingError = error.ProgrammingError
# Store flag processors (cf. 'addflagprocessor()' to register) # Store flag processors (cf. 'addflagprocessor()' to register)
_flagprocessors = { _flagprocessors = {
REVIDX_ISCENSORED: None, REVIDX_ISCENSORED: None,
} }
# Flag processors for REVIDX_ELLIPSIS.
def ellipsisreadprocessor(rl, text):
return text, False
def ellipsiswriteprocessor(rl, text):
return text, False
def ellipsisrawprocessor(rl, text):
return False
ellipsisprocessor = (
ellipsisreadprocessor,
ellipsiswriteprocessor,
ellipsisrawprocessor,
)
_mdre = re.compile('\1\n') _mdre = re.compile('\1\n')
def parsemeta(text): def parsemeta(text):
"""return (metadatadict, metadatasize)""" """return (metadatadict, metadatasize)"""
# text can be buffer, so we can't use .startswith or .index # text can be buffer, so we can't use .startswith or .index
if text[:2] != '\1\n': if text[:2] != '\1\n':
return None, None return None, None
s = _mdre.search(text, 2).start() s = _mdre.search(text, 2).start()
mtext = text[2:s] mtext = text[2:s]