This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	11637		Oct 3 2018, 12:51 PM	★	★
Diff 2	11651		Oct 3 2018, 2:58 PM	★	★
Diff 3	11655		Oct 3 2018, 4:54 PM	★	★
Diff 4	11666	rHG7a347d362a455d84bccf34347171d89724b9c9df	Oct 3 2018, 4:54 PM	★	★

Commit	Parents	Author	Summary	Date
		Gregory Szorc		Oct 3 2018, 2:58 PM

Status	Author	Revision
Closed	indygreg	D4869 revlog: rewrite censoring logic
Closed	indygreg	D4868 revlog: move loading of index data into own method
Closed	indygreg	D4867 revlog: clear revision cache on hash verification failure
Closed	indygreg	D4866 revlog: rename _cache to _revisioncache
Closed	indygreg	D4865 testing: add file storage integration for bad hashes and censoring
Closed	indygreg	D4864 testing: add file storage tests for getstrippoint() and strip()
Closed	indygreg	D4863 wireprotov2: always advertise raw repo requirements
Closed	indygreg	D4861 tests: don't be as verbose in wireprotov2 tests
Closed	indygreg	D4860 repository: define and use revision flag constants
Closed	indygreg	D4859 exchangev2: add progress bar around manifest scanning
Closed	indygreg	D4858 httppeer: report http statistics
Closed	indygreg	D4857 keepalive: track number of bytes received from an HTTP response
Closed	indygreg	D4856 keepalive: track request count and bytes sent
Closed	indygreg	D4855 url: have httpsconnection inherit from our custom HTTPConnection
Closed	indygreg	D4854 cborutil: change buffering strategy
Closed	indygreg	D4853 streamclone: don't support stream clone unless repo feature present
Closed	indygreg	D4852 localrepo: add repository feature when repo can be stream cloned

Diff 11651

mercurial/exchangev2.py

	"""Determine what file nodes are relevant given a set of manifest nodes.			"""Determine what file nodes are relevant given a set of manifest nodes.

	Returns a dict mapping file paths to dicts of file node to first manifest			Returns a dict mapping file paths to dicts of file node to first manifest
	node.			node.
	"""			"""
	ml = repo.manifestlog			ml = repo.manifestlog
	fnodes = collections.defaultdict(dict)			fnodes = collections.defaultdict(dict)

				progress = repo.ui.makeprogress(
				_('scanning manifests'), total=len(manifestnodes))

				with progress:
	for manifestnode in manifestnodes:			for manifestnode in manifestnodes:
	m = ml.get(b'', manifestnode)			m = ml.get(b'', manifestnode)

	# TODO this will pull in unwanted nodes because it takes the storage			# TODO this will pull in unwanted nodes because it takes the storage
	# delta into consideration. What we really want is something that takes			# delta into consideration. What we really want is something that takes
	# the delta between the manifest's parents. And ideally we would			# the delta between the manifest's parents. And ideally we would
	# ignore file nodes that are known locally. For now, ignore both			# ignore file nodes that are known locally. For now, ignore both
	# these limitations. This will result in incremental fetches requesting			# these limitations. This will result in incremental fetches requesting
	# data we already have. So this is far from ideal.			# data we already have. So this is far from ideal.
	md = m.readfast()			md = m.readfast()

	for path, fnode in md.items():			for path, fnode in md.items():
	fnodes[path].setdefault(fnode, manifestnode)			fnodes[path].setdefault(fnode, manifestnode)

				progress.increment()

	return fnodes			return fnodes

				martinvonzUnsubmitted Not Done should call `progress.complete()` here to remove the progress bar (or use it as a context manager) martinvonz: should call `progress.complete()` here to remove the progress bar (or use it as a context…
				indygregAuthorUnsubmitted Not Done Yes we should. I'll send an updated patch in a few minutes. indygreg: Yes we should. I'll send an updated patch in a few minutes.
	def _fetchfiles(repo, tr, remote, fnodes, linkrevs):			def _fetchfiles(repo, tr, remote, fnodes, linkrevs):
	def iterrevisions(objs, progress):			def iterrevisions(objs, progress):
	for filerevision in objs:			for filerevision in objs:
	node = filerevision[b'node']			node = filerevision[b'node']

	extrafields = {}			extrafields = {}

	for field, size in filerevision.get(b'fieldsfollowing', []):			for field, size in filerevision.get(b'fieldsfollowing', []):

This is an archive of the discontinued Mercurial Phabricator instance.

exchangev2: add progress bar around manifest scanningClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11651

mercurial/exchangev2.py

exchangev2: add progress bar around manifest scanning
ClosedPublic

Revision Contents
Changeset List