( )⚙ D4859 exchangev2: add progress bar around manifest scanning

This is an archive of the discontinued Mercurial Phabricator instance.

exchangev2: add progress bar around manifest scanning
ClosedPublic

Authored by indygreg on Oct 3 2018, 12:51 PM.

Details

Summary

This can take a long time on large repositories. Let's add a progress
bar so we don't have long periods where it isn't obvious what is
going on.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 3 2018, 12:51 PM
martinvonz added inline comments.
mercurial/exchangev2.py
344

should call progress.complete() here to remove the progress bar (or use it as a context manager)

indygreg added inline comments.Oct 3 2018, 2:56 PM
mercurial/exchangev2.py
344

Yes we should. I'll send an updated patch in a few minutes.

indygreg updated this revision to Diff 11651.Oct 3 2018, 2:58 PM
indygreg updated this revision to Diff 11655.Oct 3 2018, 4:54 PM
This revision was automatically updated to reflect the committed changes.