This is an archive of the discontinued Mercurial Phabricator instance.

tests: don't be as verbose in wireprotov2 tests
ClosedPublic

Authored by indygreg on Oct 3 2018, 12:51 PM.

Details

Summary

I don't think that printing low-level I/O and frames is beneficial to
testing command-level functionality. Protocol-level testing, yes. But
command-level functionality shouldn't care about low-level details in
most cases. This output makes tests more verbose and harder to read.
It also makes them harder to maintain, as you need to glob over various
dynamic width fields.

Let's remove these low-level details from many of the wireprotov2
tests.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 3 2018, 12:51 PM
This revision was automatically updated to reflect the committed changes.