This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4903

narrow: update TODO.rst now that we filter status in ctx
ClosedPublic

Authored by martinvonz on Oct 5 2018, 7:07 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHGeb70acc173e7: narrow: update TODO.rst now that we filter status in ctx
Summary

The comment referred to was addressed in e411774a2e0f (narrow: move
status-filtering to core and to ctx, 2018-08-02). I also think
84092edd5c88 (narrow: drop unnecessary overrides of patch, 2018-09-28)
suggests that it was the right thing to do.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 5 2018, 7:07 PM
pulkit accepted this revision.Oct 5 2018, 7:16 PM
Closed by commit rHGeb70acc173e7: narrow: update TODO.rst now that we filter status in ctx (authored by martinvonz). · Explain WhyOct 5 2018, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/TODO.rst (5 lines)

Diff 11731

hgext/narrow/TODO.rst

Integration with the share extension needs improvement. Right now Integration with the share extension needs improvement. Right now
we've seen some odd bugs. we've seen some odd bugs.
Resolve commentary on narrowrepo.wraprepo.narrowrepository.status
about the filtering of status being done at an awkward layer. This
came up the import to hgext, but nobody's got concrete improvement
ideas as of then.
Address commentary in manifest.excludedmanifestrevlog.add - Address commentary in manifest.excludedmanifestrevlog.add -
specifically we should improve the collaboration with core so that specifically we should improve the collaboration with core so that
add() never gets called on an excluded directory and we can improve add() never gets called on an excluded directory and we can improve
the stand-in to raise a ProgrammingError. the stand-in to raise a ProgrammingError.
Reason more completely about rename-filtering logic in Reason more completely about rename-filtering logic in
narrowfilelog. There could be some surprises lurking there. narrowfilelog. There could be some surprises lurking there.
Formally document the narrowspec format. Unify with sparse, if at all Formally document the narrowspec format. Unify with sparse, if at all
possible. For bonus points, unify with the server-specified narrowspec possible. For bonus points, unify with the server-specified narrowspec
format. format.
narrowrepo.setnarrowpats() or narrowspec.save() need to make sure narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
they're holding the wlock. they're holding the wlock.