This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4904

narrow: update TODO.rst now that we share format with sparse
ClosedPublic

Authored by martinvonz on Oct 5 2018, 7:07 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG56d4f88530fc: narrow: update TODO.rst now that we share format with sparse
Summary

The narrowspec format was unified with the sparse format in
f64ebe7d2259 (narrowspec: use sparse.parseconfig() to parse narrowspec
file (BC), 2018-08-03).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 5 2018, 7:07 PM
pulkit accepted this revision.Oct 5 2018, 7:15 PM
Closed by commit rHG56d4f88530fc: narrow: update TODO.rst now that we share format with sparse (authored by martinvonz). · Explain WhyOct 5 2018, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/TODO.rst (5 lines)

Diff 11732

hgext/narrow/TODO.rst

Integration with the share extension needs improvement. Right now Integration with the share extension needs improvement. Right now
we've seen some odd bugs. we've seen some odd bugs.
Address commentary in manifest.excludedmanifestrevlog.add - Address commentary in manifest.excludedmanifestrevlog.add -
specifically we should improve the collaboration with core so that specifically we should improve the collaboration with core so that
add() never gets called on an excluded directory and we can improve add() never gets called on an excluded directory and we can improve
the stand-in to raise a ProgrammingError. the stand-in to raise a ProgrammingError.
Reason more completely about rename-filtering logic in Reason more completely about rename-filtering logic in
narrowfilelog. There could be some surprises lurking there. narrowfilelog. There could be some surprises lurking there.
Formally document the narrowspec format. Unify with sparse, if at all Formally document the narrowspec format. For bonus points, unify with the
possible. For bonus points, unify with the server-specified narrowspec server-specified narrowspec format.
format.
narrowrepo.setnarrowpats() or narrowspec.save() need to make sure narrowrepo.setnarrowpats() or narrowspec.save() need to make sure
they're holding the wlock. they're holding the wlock.