This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5039

py3: add pycache to .hgignore
ClosedPublic

Authored by pulkit on Oct 12 2018, 10:22 PM.

Download Raw Diff

Details

Reviewers

durin42

Group Reviewers

hg-reviewers

Commits

rHGee9981bc8b44: py3: add __pycache__ to .hgignore

Summary

Something changed with Python 3 just like million on things. Maybe they should
named Python 3 as anaconda or cobra instead of just increasing the version
number.

This makes test-custom-filters.t pass on Python 3.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 12 2018, 10:22 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 12 2018, 10:22 PM

Herald added subscribers: mercurial-devel, mjpieters. · View Herald Transcript

pulkit added a child revision: D5040: py3: use '%d' for rev nums instead of '%s'.Oct 12 2018, 10:22 PM

a/tests/test-custom-filters.t

+++ b/tests/test-custom-filters.t
@@ -52,6 +52,7 @@
$ echo "Very very carefully." >> stuff.txt
$ hg stat
M stuff.txt
+ ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !)

It's probably better to add __pycache__ to .hgignore as we do for
prefix.py[c].

In D5039#75559, @yuja wrote:
a/tests/test-custom-filters.t

+++ b/tests/test-custom-filters.t
@@ -52,6 +52,7 @@
$ echo "Very very carefully." >> stuff.txt
$ hg stat
M stuff.txt
+ ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !)
It's probably better to add __pycache__ to .hgignore as we do for
prefix.py[c].

This revision now requires changes to proceed.Oct 13 2018, 9:21 AM

pulkit retitled this revision from py3: add more py3 specific output to test to py3: add __pycache__ to .hgignore.Nov 13 2018, 8:15 AM

pulkit updated this revision to Diff 12514.

Closed by commit rHGee9981bc8b44: py3: add __pycache__ to .hgignore (authored by pulkit). · Explain WhyNov 13 2018, 9:20 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contrib/python3-whitelist (1 line)
M			tests/test-custom-filters.t (1 line)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	11973		Oct 12 2018, 10:22 PM	★	★
Diff 2	12514		Nov 13 2018, 8:15 AM	★	★
Diff 3	12515	rHGee9981bc8b44cbee1c280813faa4aa03544231d4	Oct 12 2018, 10:09 PM	★	★

Status	Author	Revision
Closed	pulkit	D5042 py3: add some glob to make output compatible with python 3
Closed	pulkit	D5041 py3: add a b'' prefix in tests/test-requires.t
Closed	pulkit	D5040 py3: use '%d' for rev nums instead of '%s'
Closed	pulkit	D5039 py3: add __pycache__ to .hgignore
Closed	pulkit	D5038 py3: more globing of things to make output compatible between py2 and py3
Closed	pulkit	D5037 py3: use stringutil.pprint() instead of '%r'
Closed	pulkit	D5036 py3: use '%d' for integers instead of '%s'
Closed	pulkit	D5035 py3: add some py3 specific output to test
Closed	pulkit	D5034 py3: use stringutil.pprint() in color.py instead of '%r'
Closed	pulkit	D5033 py3: add b'' prefixes in tests/test-progress.t
Closed	pulkit	D5032 py3: add b'' prefixes to tests/test-keyword.t
Closed	pulkit	D5031 py3: use stringutil.pprint() if we are printing bool values
Closed	pulkit	D5030 py3: glob some difference between py2 and py3 output
Closed	pulkit	D5029 py3: byteify tests/wireprotosimplecache.py
Closed	pulkit	D5028 py3: add b'' prefixes in tests/test-help.t
Closed	pulkit	D5027 py3: use sys.stdout.buffer for binary output in tests/svnxml.py
Closed	pulkit	D5026 py3: use '%s' instead of %r in hgext/convert/subversion.py
Closed	pulkit	D5025 py3: make test-contrib-perf.t work on python 3
Closed	pulkit	D5024 py3: add 3 more passing tests to whitelist caught by buildbot
Closed	pulkit	D5023 py3: add some r'' prefixes in hgext/narrow/narrowwirepeer.py

Diff 12515

contrib/python3-whitelist

	test-convert-hg-sink.t			test-convert-hg-sink.t
	test-convert-hg-source.t			test-convert-hg-source.t
	test-convert-hg-startrev.t			test-convert-hg-startrev.t
	test-convert-splicemap.t			test-convert-splicemap.t
	test-convert-tagsbranch-topology.t			test-convert-tagsbranch-topology.t
	test-copy-move-merge.t			test-copy-move-merge.t
	test-copy.t			test-copy.t
	test-copytrace-heuristics.t			test-copytrace-heuristics.t
				test-custom-filters.t
	test-debugbuilddag.t			test-debugbuilddag.t
	test-debugbundle.t			test-debugbundle.t
	test-debugcommands.t			test-debugcommands.t
	test-debugextensions.t			test-debugextensions.t
	test-debugindexdot.t			test-debugindexdot.t
	test-debugrename.t			test-debugrename.t
	test-default-push.t			test-default-push.t
	test-diff-antipatience.t			test-diff-antipatience.t

tests/test-custom-filters.t

	> repo.adddatafilter(b'stripprefix:', stripprefix)			> repo.adddatafilter(b'stripprefix:', stripprefix)
	> repo.adddatafilter(b'insertprefix:', insertprefix)			> repo.adddatafilter(b'insertprefix:', insertprefix)
	> EOF			> EOF

	$ cat > .hgignore <<EOF			$ cat > .hgignore <<EOF
	> .hgignore			> .hgignore
	> prefix.py			> prefix.py
	> prefix.pyc			> prefix.pyc
				> __pycache__/
	> EOF			> EOF

	$ cat > stuff.txt <<EOF			$ cat > stuff.txt <<EOF
	> Copyright 2046, The Masters			> Copyright 2046, The Masters
	> Some stuff to ponder very carefully.			> Some stuff to ponder very carefully.
	> EOF			> EOF
	$ hg add stuff.txt			$ hg add stuff.txt
	$ hg ci -m stuff			$ hg ci -m stuff