This is an archive of the discontinued Mercurial Phabricator instance.

exchange: pass includepats and excludepats as arguments to getbundle()
ClosedPublic

Authored by pulkit on Oct 16 2018, 12:13 PM.

Details

Summary

This will help in implementing narrow stream clones. Also narrow extension used
to add these arguments, now we add them by default if they are not empty.

Since reading includepats and excludepats on the server only works when narrow
is enabled, we check if narrow if enabled or not before passing them.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 16 2018, 12:13 PM
indygreg requested changes to this revision.Oct 16 2018, 12:47 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/exchange.py
1631

I'd prefer if we didn't send empty arguments across the wire if it can be avoided. I'm pretty sure it can be avoided in this case.

More importantly, the sending of these arguments needs to be conditional on a server capabilitiy because servers barf when receiving an unknown argument (the type of the argument isn't registered and servers barf when trying to decode the argument value).

This revision now requires changes to proceed.Oct 16 2018, 12:47 PM
pulkit edited the summary of this revision. (Show Details)Oct 17 2018, 10:52 AM
pulkit updated this revision to Diff 12207.
indygreg accepted this revision.Oct 17 2018, 11:15 AM
This revision is now accepted and ready to land.Oct 17 2018, 11:15 AM
pulkit updated this revision to Diff 12231.Oct 18 2018, 6:38 AM
pulkit updated this revision to Diff 12258.Oct 19 2018, 9:01 AM
This revision was automatically updated to reflect the committed changes.