( )⚙ D5129 remotefilelog: rename wireproto methods and remaining capabilities

This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: rename wireproto methods and remaining capabilities
ClosedPublic

Authored by durin42 on Oct 16 2018, 5:45 PM.

Details

Summary

This is a mess, in part because there should be more constants
throughout. I know we typically do exp- instead of the x_ business in
this change, but I also had to use this in some function names, so I
figured until I can break that coupling I'd go with this. If it's too
unpleasant during review, let me know and I can probably clean it up
some more.

  1. no-check-commit due to new foo_bar naming - too hard to avoid right now :(

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 16 2018, 5:45 PM
indygreg accepted this revision.Oct 17 2018, 2:56 AM
indygreg added a subscriber: indygreg.

Yuck. But the names don't matter much for an experimental feature. And the wireproto v1 peer batching code dictates certain things with regards to naming. So our hands are a bit tied here :/

This revision is now accepted and ready to land.Oct 17 2018, 2:56 AM
This revision was automatically updated to reflect the committed changes.