( )⚙ D5229 runbgcommand: import concerns about creationflags on Windows from D1701

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5229

runbgcommand: import concerns about creationflags on Windows from D1701
ClosedPublic

Authored by lothiraldan on Nov 6 2018, 5:54 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1d3bed7d2923: procutil: import concerns about creationflags on Windows from D1701
Summary

I don't have the need anymore for the change in D1701 nor the time to
investigate the changes on all supported Windows platforms.

I import the stuff I learned on D1701 in the runbgcommand so the next people
working on it can starts from there.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Nov 6 2018, 5:54 AM
Closed by commit rHG1d3bed7d2923: procutil: import concerns about creationflags on Windows from D1701 (authored by lothiraldan). · Explain WhyNov 6 2018, 7:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/procutil.py (3 lines)

Diff 12444

mercurial/utils/procutil.py

if shouldbail: if shouldbail:
raise KeyboardInterrupt raise KeyboardInterrupt
if pycompat.iswindows: if pycompat.iswindows:
# no fork on Windows, but we can create a detached process # no fork on Windows, but we can create a detached process
# https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863.aspx # https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863.aspx
# No stdlib constant exists for this value # No stdlib constant exists for this value
DETACHED_PROCESS = 0x00000008 DETACHED_PROCESS = 0x00000008
# Following creation flags might create a console GUI window.
# Using subprocess.CREATE_NEW_CONSOLE might helps.
# See https://phab.mercurial-scm.org/D1701 for discussion
_creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP _creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP
def runbgcommand(script, env, shell=False, stdout=None, stderr=None): def runbgcommand(script, env, shell=False, stdout=None, stderr=None):
'''Spawn a command without waiting for it to finish.''' '''Spawn a command without waiting for it to finish.'''
# we can't use close_fds *and* redirect stdin. I'm not sure that we # we can't use close_fds *and* redirect stdin. I'm not sure that we
# need to because the detached process has no console connection. # need to because the detached process has no console connection.
subprocess.Popen( subprocess.Popen(
tonativestr(script), tonativestr(script),