This is an archive of the discontinued Mercurial Phabricator instance.

narrow: when narrowing, write new narrowspec before removing revlogs
ClosedPublic

Authored by martinvonz on Dec 20 2018, 1:11 PM.

Reviewers

durin42
pulkit

Group Reviewers

hg-reviewers

Commits

Summary

If revlogs were removed and then the process crashed before the
narrowspec was written, the repo would be corrupt.

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			hgext/narrow/narrowcommands.py (5 lines)

Commit	Parents	Author	Summary	Date
		Martin von Zweigbergk		Dec 5 2018, 6:30 PM

Status	Author	Revision
Closed	martinvonz	D5469 manifest: accept narrowmatch into constructor instead of getting from repo
Closed	martinvonz	D5468 narrow: replace "ui.warn(); return 1" by "raise error.Abort()"
Closed	martinvonz	D5467 narrow: when narrowing, write new narrowspec before removing revlogs
Closed	martinvonz	D5466 repository: update interface signature of narrowmatch()

	if visit == 'all':			if visit == 'all':
	break			break
	if not include:			if not include:
	todelete.append(f)			todelete.append(f)

	repo.destroying()			repo.destroying()

	with repo.transaction("narrowing"):			with repo.transaction("narrowing"):
				# Update narrowspec before removing revlogs, so repo won't be
				# corrupt in case of crash
				repo.setnarrowpats(newincludes, newexcludes)

	for f in todelete:			for f in todelete:
	ui.status(_('deleting %s\n') % f)			ui.status(_('deleting %s\n') % f)
	util.unlinkpath(repo.svfs.join(f))			util.unlinkpath(repo.svfs.join(f))
	repo.store.markremoved(f)			repo.store.markremoved(f)

	_narrowcleanupwdir(repo, oldincludes, oldexcludes, newincludes,			_narrowcleanupwdir(repo, oldincludes, oldexcludes, newincludes,
	newexcludes, oldmatch, newmatch)			newexcludes, oldmatch, newmatch)
	repo.setnarrowpats(newincludes, newexcludes)

	repo.destroyed()			repo.destroyed()

	def _widen(ui, repo, remote, commoninc, oldincludes, oldexcludes,			def _widen(ui, repo, remote, commoninc, oldincludes, oldexcludes,
	newincludes, newexcludes):			newincludes, newexcludes):
	newmatch = narrowspec.match(repo.root, newincludes, newexcludes)			newmatch = narrowspec.match(repo.root, newincludes, newexcludes)

	# for now we assume that if a server has ellipses enabled, we will be			# for now we assume that if a server has ellipses enabled, we will be