This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5480

tests: show that debugrebuilddirstate is broken with narrow+sparse
ClosedPublic

Authored by pulkit on Dec 24 2018, 8:19 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG76dcf7958c5f: tests: show that debugrebuilddirstate is broken with narrow+sparse
Summary

This adds a test to show that debugrebuildirstate is broken when both narrow and
sparse extensions are enabled.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 24 2018, 8:19 AM
Closed by commit rHG76dcf7958c5f: tests: show that debugrebuilddirstate is broken with narrow+sparse (authored by pulkit). · Explain WhyJan 9 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Jan 11 2019, 10:04 PM

+ $ hg debugrebuilddirstate
+ unknown exception encountered, please report by visiting
+ https://mercurial-scm.org/wiki/BugTracker
+ Python 2.7.12 (default, Nov 12 2018, 14:36:49) [GCC 5.4.0 20160609]
+ Mercurial Distributed SCM (version 4.8.1+588-479a5ea51ccc+20181224)
+ ** Extensions loaded: narrow, sparse
+ Traceback (most recent call last):
+ File "/place/vartmp/hgtests.zMelCK/install/bin/hg", line 43, in <module>
+ dispatch.run()

Next time, please don't include a raw traceback, which makes the test
unstable.

Revision Contents
Changeset List

PathPackages
Mtests/test-narrow-sparse.t (42 lines)

Diff 13102

tests/test-narrow-sparse.t

dotencode dotencode
fncache fncache
generaldelta generaldelta
narrowhg-experimental narrowhg-experimental
revlogv1 revlogv1
sparserevlog sparserevlog
store store
treemanifest (tree !) treemanifest (tree !)
$ hg debugrebuilddirstate
** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker
** Python 2.7.12 (default, Nov 12 2018, 14:36:49) [GCC 5.4.0 20160609]
** Mercurial Distributed SCM (version 4.8.1+588-479a5ea51ccc+20181224)
** Extensions loaded: narrow, sparse
Traceback (most recent call last):
File "/place/vartmp/hgtests.zMelCK/install/bin/hg", line 43, in <module>
dispatch.run()
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 99, in run
status = dispatch(req)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 225, in dispatch
ret = _runcatch(req) or 0
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 376, in _runcatch
return _callcatch(ui, _runcatchfunc)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 384, in _callcatch
return scmutil.callcatch(ui, func)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/scmutil.py", line 166, in callcatch
return func()
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 367, in _runcatchfunc
return _dispatch(req)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 1021, in _dispatch
cmdpats, cmdoptions)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 756, in runcommand
ret = _runcommand(ui, options, cmd, d)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 1030, in _runcommand
return cmdfunc()
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/dispatch.py", line 1018, in <lambda>
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/util.py", line 1670, in check
return func(*args, **kwargs)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/debugcommands.py", line 1998, in debugrebuilddirstate
dirstate.rebuild(ctx.node(), ctx.manifest(), changedfiles)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/hgext/narrow/narrowdirstate.py", line 60, in rebuild
super(narrowdirstate, self).rebuild(parent, allfiles, changedfiles)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/mercurial/extensions.py", line 437, in closure
return func(*(args + a), **kw)
File "/place/vartmp/hgtests.zMelCK/install/lib/python/hgext/sparse.py", line 213, in _rebuild
allfiles = allfiles.matches(matcher)
AttributeError: 'list' object has no attribute 'matches'
[1]