histedit: add warning message on editing tagged commits (issue4017)
ClosedPublic

Authored by navaneeth.suresh on Jan 3 2019, 1:33 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
This revision was automatically updated to reflect the committed changes.

Thanks for queuing!

mharbison72 added inline comments.
hgext/histedit.py
1707

Out of curiosity, why the sleep?

hgext/histedit.py
1707

Otherwise, the user won't be able to see the warning as the editor opens for histedit.

mharbison72 added inline comments.Jan 5 2019, 9:09 PM
hgext/histedit.py
1707

Oh, OK. Does it make sense to make this an interactive prompt to continue/bail instead, to ensure this isn't missed? (Don't feel obligated- I wasn't going to say anything because I couldn't think of any other commands that prompt like this. And then I remembered that absorb does.)

yuja added a subscriber: yuja.Jan 5 2019, 9:14 PM

> mharbison72 wrote in histedit.py:1707
> Out of curiosity, why the sleep?

Otherwise, the user won't be able to see the warning as the editor opens for histedit.

Maybe ui.prompt()?

I don't like this sort of sleep() use. 1 sec wouldn't be enough to notice the
warning.

@mharbison72 @yuja Thank you for the suggestions. I've created a follow-up patch making the suggested changes. Please see D5494.