Page MenuHomePhabricator

histedit: add user input to warning message on editing tagged commits
ClosedPublic

Authored by navaneeth.suresh on Jan 5 2019, 11:06 PM.

Details

Summary

This is a follow-up patch to D5489.

Now, the user will be able to input yes/no(default) on the warning message. Initially, it was the sleep of 1s and histedit window opens. Changes were made as suggested by @mharbison72 and @yuja.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

navaneeth.suresh edited the summary of this revision. (Show Details)Jan 5 2019, 11:11 PM
navaneeth.suresh added subscribers: mharbison72, yuja.
This revision was automatically updated to reflect the committed changes.
pulkit added a subscriber: pulkit.Jan 9 2019, 3:03 PM

Sorry for bumping on this now, can you add tests for this as follow-up?

In D5494#81855, @pulkit wrote:

Sorry for bumping on this now, can you add tests for this as follow-up?

My bad. Doing that right away!