This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5734

url: add some defensive asserts on expected incoming types
ClosedPublic

Authored by durin42 on Jan 29 2019, 3:12 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbc776c31c093: url: add some defensive asserts on expected incoming types
Summary

Our type handling is a nightmare here, and we're loading passwords to
do network IO, so we can afford to be potentially-slow but pedantic
here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 29 2019, 3:12 PM
Closed by commit rHGbc776c31c093: url: add some defensive asserts on expected incoming types (authored by durin42). · Explain WhyJan 29 2019, 4:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/url.py (2 lines)

Diff 13556

mercurial/url.py

def __init__(self, ui, passwddb): def __init__(self, ui, passwddb):
self.ui = ui self.ui = ui
self.passwddb = passwddb self.passwddb = passwddb
def add_password(self, realm, uri, user, passwd): def add_password(self, realm, uri, user, passwd):
return self.passwddb.add_password(realm, uri, user, passwd) return self.passwddb.add_password(realm, uri, user, passwd)
def find_user_password(self, realm, authuri): def find_user_password(self, realm, authuri):
assert isinstance(realm, (type(None), str))
assert isinstance(authuri, str)
authinfo = self.passwddb.find_user_password(realm, authuri) authinfo = self.passwddb.find_user_password(realm, authuri)
user, passwd = authinfo user, passwd = authinfo
if user and passwd: if user and passwd:
self._writedebug(user, passwd) self._writedebug(user, passwd)
return (user, passwd) return (user, passwd)
if not user or not passwd: if not user or not passwd:
res = httpconnectionmod.readauthforuri(self.ui, authuri, user) res = httpconnectionmod.readauthforuri(self.ui, authuri, user)