This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5955

watchman: ignore some of watchman errors
ClosedPublic

Authored by lothiraldan on Feb 13 2019, 11:22 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG76361969662a: watchman: ignore some of watchman errors
Summary

Don't display 'illegal_fstypes' errors. In environments with network
filesystems, the error messages are quickly pilling up and polluting outputs.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Feb 13 2019, 11:22 AM
lothiraldan added a subscriber: indygreg.Feb 20 2019, 4:37 AM

@indygreg I've update the patchs with your reviews.

lothiraldan added a comment.Feb 27 2019, 4:47 AM

Gentle ping on this series

pulkit accepted this revision.Mar 16 2019, 7:19 PM
Closed by commit rHG76361969662a: watchman: ignore some of watchman errors (authored by lothiraldan). · Explain WhyMar 16 2019, 7:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fsmonitor/__init__.py (3 lines)

Diff 14528

hgext/fsmonitor/__init__.py

# and will disable itself when encountering one of these: # and will disable itself when encountering one of these:
_blacklist = ['largefiles', 'eol'] _blacklist = ['largefiles', 'eol']
def _handleunavailable(ui, state, ex): def _handleunavailable(ui, state, ex):
"""Exception handler for Watchman interaction exceptions""" """Exception handler for Watchman interaction exceptions"""
if isinstance(ex, watchmanclient.Unavailable): if isinstance(ex, watchmanclient.Unavailable):
# experimental config: fsmonitor.verbose # experimental config: fsmonitor.verbose
if ex.warn and ui.configbool('fsmonitor', 'verbose'): if ex.warn and ui.configbool('fsmonitor', 'verbose'):
if 'illegal_fstypes' not in str(ex):
ui.warn(str(ex) + '\n') ui.warn(str(ex) + '\n')
if ex.invalidate: if ex.invalidate:
state.invalidate() state.invalidate()
# experimental config: fsmonitor.verbose # experimental config: fsmonitor.verbose
if ui.configbool('fsmonitor', 'verbose'): if ui.configbool('fsmonitor', 'verbose'):
ui.log('fsmonitor', 'Watchman unavailable: %s\n', ex.msg) ui.log('fsmonitor', 'Watchman unavailable: %s\n', ex.msg)
else: else:
ui.log('fsmonitor', 'Watchman exception: %s\n', ex) ui.log('fsmonitor', 'Watchman exception: %s\n', ex)