This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6205

branchmap: prevent using __getitem__() in branchheads()
ClosedPublic

Authored by pulkit on Apr 5 2019, 9:31 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG29c22496dd97: branchmap: prevent using __getitem__() in branchheads()
Summary

branchheads() can directly use self._entries instead.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Apr 5 2019, 9:31 AM
Closed by commit rHG29c22496dd97: branchmap: prevent using __getitem__() in branchheads() (authored by pulkit). · Explain WhyApr 12 2019, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (2 lines)

Diff 14725

mercurial/branchmap.py

tipmost closed head on branch. tipmost closed head on branch.
Raise KeyError for unknown branch.''' Raise KeyError for unknown branch.'''
return self._branchtip(self[branch])[0] return self._branchtip(self[branch])[0]
def iteropen(self, nodes): def iteropen(self, nodes):
return (n for n in nodes if n not in self._closednodes) return (n for n in nodes if n not in self._closednodes)
def branchheads(self, branch, closed=False): def branchheads(self, branch, closed=False):
heads = self[branch] heads = self._entries[branch]
if not closed: if not closed:
heads = list(self.iteropen(heads)) heads = list(self.iteropen(heads))
return heads return heads
def iterbranches(self): def iterbranches(self):
for bn, heads in self.iteritems(): for bn, heads in self.iteritems():
yield (bn, heads) + self._branchtip(heads) yield (bn, heads) + self._branchtip(heads)