This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6209

branchcache: don't verify closed nodes in iteropen()
ClosedPublic

Authored by pulkit on Apr 5 2019, 9:31 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG7c9d4cf23adf: branchcache: don't verify closed nodes in iteropen()
Summary

We expect that the nodes passed to iteropen() will be verified. We are only
testing for membership in closed nodes set, so we don't need to verify the whole
closed nodes set.

This will speed up calculating branchheads() when there are lot of closed nodes
related to other branches.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (1 line)

Diff 14678

mercurial/branchmap.py

def branchtip(self, branch): def branchtip(self, branch):
'''Return the tipmost open head on branch head, otherwise return the '''Return the tipmost open head on branch head, otherwise return the
tipmost closed head on branch. tipmost closed head on branch.
Raise KeyError for unknown branch.''' Raise KeyError for unknown branch.'''
return self._branchtip(self[branch])[0] return self._branchtip(self[branch])[0]
def iteropen(self, nodes): def iteropen(self, nodes):
self._verifyclosed()
return (n for n in nodes if n not in self._closednodes) return (n for n in nodes if n not in self._closednodes)
def branchheads(self, branch, closed=False): def branchheads(self, branch, closed=False):
self._verifybranch(branch) self._verifybranch(branch)
heads = self._entries[branch] heads = self._entries[branch]
if not closed: if not closed:
heads = list(self.iteropen(heads)) heads = list(self.iteropen(heads))
return heads return heads