( )⚙ D6239 branchcache: fix the docstring of _verifybranch()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6239

branchcache: fix the docstring of _verifybranch()
ClosedPublic

Authored by pulkit on Apr 16 2019, 8:27 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd9dc0896e1d3: branchcache: fix the docstring of _verifybranch()
Summary

Initially the function was designed to support verifying all branches but later
I decided to have a separate function. I forget to remove the doc related to
that. Thanks to Yuya for spotting this in review.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Apr 16 2019, 8:27 AM
Closed by commit rHGd9dc0896e1d3: branchcache: fix the docstring of _verifybranch() (authored by pulkit). · Explain WhyApr 16 2019, 10:54 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (3 lines)

Diff 14757

mercurial/branchmap.py

return return
for node in self._closednodes: for node in self._closednodes:
if not self._hasnode(node): if not self._hasnode(node):
_unknownnode(node) _unknownnode(node)
self._closedverified = True self._closedverified = True
def _verifybranch(self, branch): def _verifybranch(self, branch):
""" verify head nodes for the given branch. If branch is None, verify """ verify head nodes for the given branch. """
for all the branches """
if branch not in self._entries or branch in self._verifiedbranches: if branch not in self._entries or branch in self._verifiedbranches:
return return
for n in self._entries[branch]: for n in self._entries[branch]:
if not self._hasnode(n): if not self._hasnode(n):
_unknownnode(n) _unknownnode(n)
self._verifiedbranches.add(branch) self._verifiedbranches.add(branch)