Page MenuHomePhabricator

narrow: also warn when not deleting untracked or ignored files
ClosedPublic

Authored by martinvonz on Apr 17 2019, 1:58 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 17 2019, 1:58 PM
rdamazio added inline comments.
mercurial/narrowspec.py
311

Just do a loop for each one? You probably also don't need them to be sets.

martinvonz added inline comments.Apr 17 2019, 5:16 PM
mercurial/narrowspec.py
311

I did it that way at first. Then I changed it because I figured it might be a harder to read if dirty, untracked, and ignored files in single a directory were spread out in three places. OTOH, both hg status and hg revert already do it that way, so I guess we should follow them. I'll change it back here.

martinvonz updated this revision to Diff 14807.Apr 17 2019, 5:19 PM
rdamazio accepted this revision.Apr 17 2019, 6:44 PM
pulkit accepted this revision.Apr 18 2019, 7:20 AM
This revision was automatically updated to reflect the committed changes.