Page MenuHomePhabricator

rust-dirstate: add rust implementation of `parse_dirstate` and `pack_dirstate`
ClosedPublic

Authored by Alphare on May 6 2019, 5:03 PM.

Details

Summary

Working towards the goal of having a complete Rust implementation of
hg status, these two utils are a first step of many to be taken
to improve performance and code maintainability.

Two dependencies have been added: memchr and byteorder.
Both of them have been written by reputable community members and are
very mature crates.
The Rust code will often need to use their byte-oriented functions.

A few unit tests have been added and may help future development and debugging.

In a future patch that uses parse_dirstate to stat the working tree in
parallel - which neither the Python nor the C implementations do - actual
performance improvements will be seen for larger repositories.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.May 6 2019, 5:03 PM
kevincox requested changes to this revision.May 10 2019, 11:04 AM
kevincox added inline comments.
rust/hg-core/src/dirstate.rs
17

You have a lot of tuples here an it is unclear what they represent. I would much prefer making structs for these, then you can give the members names which will really help the reader.

35

You check for PARENT_SIZE then index by PERENT_SIZE*2. This will panic if the size is between the two.

37

It would be nice to define the above the definition of parents and use it in that slice.

44

This isn't a very useful name. Maybe entry or entry_bytes.

49

This is a lot of manual index numbers. It would probably me more clear to wrap it in a Cursor and use https://docs.rs/byteorder/1.3.1/byteorder/trait.ReadBytesExt.html to read the values. This way the cursor is automatically moved to match the data you have read.

This revision now requires changes to proceed.May 10 2019, 11:04 AM
Alphare marked 5 inline comments as done.May 13 2019, 5:47 AM
Alphare updated this revision to Diff 15066.

Thanks for review. I think I've addressed all of your points.

rust/hg-core/src/dirstate.rs
35

Good catch, thanks!

This revision was automatically updated to reflect the committed changes.