This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6425

rust-discovery: exposing sampling to python
ClosedPublic

Authored by gracinet on May 22 2019, 12:50 PM.

Details

Reviewers
kevincox
Group Reviewers
hg-reviewers
Commits
rHG1c4b5689bef5: rust-discovery: exposing sampling to python
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

gracinet created this revision.May 22 2019, 12:50 PM
kevincox accepted this revision.May 23 2019, 10:55 AM
gracinet updated this revision to Diff 15483.Jun 13 2019, 9:32 AM
Alphare updated this revision to Diff 15935.Jul 17 2019, 12:30 PM
Alphare updated this revision to Diff 16013.Jul 23 2019, 5:15 AM
gracinet added a commit: rHG1c4b5689bef5: rust-discovery: exposing sampling to python.Aug 14 2019, 4:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG1c4b5689bef5: rust-discovery: exposing sampling to python (authored by gracinet). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-cpython/src/discovery.rs (28 lines)

Diff 15224

rust/hg-cpython/src/discovery.rs

//! //!
//! # Classes visible from Python: //! # Classes visible from Python:
//! - [`PartialDiscover`] is the Rust implementation of //! - [`PartialDiscover`] is the Rust implementation of
//! `mercurial.setdiscovery.partialdiscovery`. //! `mercurial.setdiscovery.partialdiscovery`.
use crate::conversion::{py_set, rev_pyiter_collect}; use crate::conversion::{py_set, rev_pyiter_collect};
use cindex::Index; use cindex::Index;
use cpython::{ use cpython::{
ObjectProtocol, PyDict, PyModule, PyObject, PyResult, Python, ObjectProtocol, PyDict, PyModule, PyObject, PyResult, PyTuple, Python,
PythonObject, ToPyObject, PythonObject, ToPyObject,
}; };
use exceptions::GraphError; use exceptions::GraphError;
use hg::discovery::PartialDiscovery as CorePartialDiscovery; use hg::discovery::PartialDiscovery as CorePartialDiscovery;
use hg::Revision; use hg::Revision;
use std::cell::RefCell; use std::cell::RefCell;
def commonheads(&self) -> PyResult<PyObject> { def commonheads(&self) -> PyResult<PyObject> {
py_set( py_set(
py, py,
&self.inner(py).borrow().common_heads() &self.inner(py).borrow().common_heads()
.map_err(|e| GraphError::pynew(py, e))? .map_err(|e| GraphError::pynew(py, e))?
) )
} }
def takefullsample(&self, _headrevs: PyObject,
size: usize) -> PyResult<PyObject> {
let mut inner = self.inner(py).borrow_mut();
let sample = inner.take_full_sample(size)
.map_err(|e| GraphError::pynew(py, e))?;
let as_vec: Vec<PyObject> = sample
.iter()
.map(|rev| rev.to_py_object(py).into_object())
.collect();
Ok(PyTuple::new(py, as_vec.as_slice()).into_object())
}
def takequicksample(&self, headrevs: PyObject,
size: usize) -> PyResult<PyObject> {
let mut inner = self.inner(py).borrow_mut();
let revsvec: Vec<Revision> = rev_pyiter_collect(py, &headrevs)?;
let sample = inner.take_quick_sample(revsvec, size)
.map_err(|e| GraphError::pynew(py, e))?;
let as_vec: Vec<PyObject> = sample
.iter()
.map(|rev| rev.to_py_object(py).into_object())
.collect();
Ok(PyTuple::new(py, as_vec.as_slice()).into_object())
}
}); });
/// Create the module, with __package__ given from parent /// Create the module, with __package__ given from parent
pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> { pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> {
let dotted_name = &format!("{}.discovery", package); let dotted_name = &format!("{}.discovery", package);
let m = PyModule::new(py, dotted_name)?; let m = PyModule::new(py, dotted_name)?;
m.add(py, "__package__", package)?; m.add(py, "__package__", package)?;
m.add( m.add(