Page MenuHomePhabricator

narrow: factor out logic to build ellipses related b2parts in separate fn
ClosedPublic

Authored by pulkit on May 22 2019, 5:47 PM.

Details

Summary

This will help us switch more cleanly to using wireprotocol commands instead of
using exchange.pull() which exchanges more things then required.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 22 2019, 5:47 PM
martinvonz added inline comments.May 23 2019, 12:42 PM
hgext/narrow/narrowbundle2.py
69

nit: common and heads are a closely related, so I'd put heads right after common here

79–80

nit: we generally work with binary nodeids, so I'd expect this new function to get the nodeids in binary form already

This revision was automatically updated to reflect the committed changes.