Page MenuHomePhabricator

narrow: refactor code around widening complicated by previous patch
ClosedPublic

Authored by pulkit on May 22 2019, 5:47 PM.

Details

Summary

Previous patch while adding support for using narrow_widen wireproto command,
complicated the code a bit. This patch refactors that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 22 2019, 5:47 PM
pulkit updated this revision to Diff 15272.May 28 2019, 9:42 AM
pulkit updated this revision to Diff 15335.Jun 4 2019, 11:23 AM
martinvonz added inline comments.Jun 4 2019, 1:36 PM
hgext/narrow/narrowcommands.py
281

nit: looks like this can be deleted

282

nit: looks like these can be moved to before line 294

pulkit updated this revision to Diff 15337.Jun 4 2019, 1:52 PM
This revision was automatically updated to reflect the committed changes.