( )⚙ D664 changegroup: replace getsubset with makechangegroup

This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: replace getsubset with makechangegroup
ClosedPublic

Authored by durham on Sep 10 2017, 10:06 PM.

Details

Summary

The current changegroup APIs are a bit of a mess. Currently you can use
getsubsetraw, getsubset, changegroupsubset, getlocalchangegroupraw,
getchangegroup, and getlocalchangroup to produce changegroups. This patch is the
beginning of a refactor to boil all of that away to just makechangegroup and
makestream.

The first step adds the new functions and replaces getsubset function with them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Sep 10 2017, 10:06 PM
indygreg accepted this revision.Sep 11 2017, 6:22 PM
indygreg added a subscriber: indygreg.

Could I request a follow-up to add docstrings to our new preferred APIs?

Otherwise, this entire series looks great! Thank you for the cleanup work. These APIs were in desperate need of it.

This revision is now accepted and ready to land.Sep 11 2017, 6:22 PM
This revision was automatically updated to reflect the committed changes.