Page MenuHomePhabricator

config: add experimental argument to the config registrar
ClosedPublic

Authored by navaneeth.suresh on Aug 15 2019, 10:22 AM.

Details

Summary

Until now, there are almost 28 config items which are considered as
experimental but, not present in the experimental section of
the registrar. This patch adds an experimental argument to the
config registrar to mark such config items.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
pulkit added a subscriber: pulkit.Aug 17 2019, 3:25 PM
pulkit added inline comments.
contrib/perf.py
244

This breaks contrib/perf.py with older versions of mercurial. Can you send a compatibility fix as followup?

contrib/perf.py
244

I'm not sure I understood that. Do you want me to remove the changes in contrib/perf.py?

This change breaks contrib/perf.py on older version (that extension is
special and we expect it to be compatible with older version). Can you
follow up with a fix ?

(note: when doing this kind of change it is often useful to have
different patch for adding the feature and using it. It help to deal
with this kind of case).