( )⚙ D6836 interfaces: introduce an interface for dirstate implementations

This is an archive of the discontinued Mercurial Phabricator instance.

interfaces: introduce an interface for dirstate implementations
ClosedPublic

Authored by durin42 on Sep 10 2019, 10:01 AM.

Details

Summary

As usual with adding interface definitions, this describes the way
things are, not the way we'd like things to be. There are some clear
problems in the interface right now (eg ._map leaks in a few places),
but I have plans to clean those up. There are also many missing
docstrings, but again, we'll make a second pass to clean that up.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 10 2019, 10:01 AM
indygreg accepted this revision.Sep 11 2019, 10:47 PM
This revision is now accepted and ready to land.Sep 11 2019, 10:47 PM
Alphare added inline comments.
mercurial/interfaces/dirstate.py
38

Shouldn't this be removed?

pulkit accepted this revision.Sep 14 2019, 11:11 AM