This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6895

sidedata: make sure we don't use the flag if there are not sidedata
ClosedPublic

Authored by marmoute on Sep 27 2019, 12:17 PM.

Details

Reviewers
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG7902001aaf41: sidedata: make sure we don't use the flag if there are not sidedata
Summary

Ensuring this at this level seems safer than relying on caller doing the right
thing.

G: changed mercurial/revlog.py

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (1 line)

Diff 16740

mercurial/revlog.py

multiple calls multiple calls
""" """
if link == nullrev: if link == nullrev:
raise error.RevlogError(_("attempted to add linkrev -1 to %s") raise error.RevlogError(_("attempted to add linkrev -1 to %s")
% self.indexfile) % self.indexfile)
if sidedata is None: if sidedata is None:
sidedata = {} sidedata = {}
flags = flags & ~REVIDX_SIDEDATA
elif not self.hassidedata: elif not self.hassidedata:
raise error.ProgrammingError( raise error.ProgrammingError(
_("trying to add sidedata to a revlog who don't support them") _("trying to add sidedata to a revlog who don't support them")
) )
else: else:
flags |= REVIDX_SIDEDATA flags |= REVIDX_SIDEDATA
if flags: if flags: