This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6974

examples: include a sample of how to use black with fix
ClosedPublic

Authored by durin42 on Oct 5 2019, 10:06 AM.

Download Raw Diff

Tags

None

Subscribers

mjpieters, indygreg, mercurial-devel

Details

Reviewers

Group Reviewers

Commits

rHG31c1a5376745: examples: include a sample of how to use black with fix
rHG47cba083adb7: examples: include a sample of how to use black with fix

Summary

It's commented out for now since my patch hasn't landed, but we can
uncomment it when that lands.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 5 2019, 10:06 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptOct 5 2019, 10:06 AM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

This needs hgext/fsmonitor/pywatchman added to the list.

This revision now requires changes to proceed.Oct 5 2019, 10:35 AM

durin42 updated this revision to Diff 16834.Oct 5 2019, 11:47 AM

durin42 edited parent revisions, added: D6993: black: add a pyproject.toml that contains our black settings; removed: D6973: mangler: stop rewriting string constants to be bytes literals.Oct 6 2019, 9:50 AM

durin42 added a child revision: D6342: style: run a patched black on a subset of mercurial.

I'll add the fsmonitor exclusion in flight.

This revision is now accepted and ready to land.Oct 6 2019, 9:54 AM

durin42 added a commit: rHG47cba083adb7: examples: include a sample of how to use black with fix.Oct 6 2019, 9:56 AM

Closed by commit rHG47cba083adb7: examples: include a sample of how to use black with fix (authored by durin42). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: mjpieters. · View Herald TranscriptOct 6 2019, 9:56 AM

durin42 added a commit: rHG31c1a5376745: examples: include a sample of how to use black with fix.Oct 6 2019, 10:27 AM

Revision Contents
Changeset List

			Path	Packages
M			contrib/examples/fix.hgrc (4 lines)

Diff 16834

contrib/examples/fix.hgrc

	[fix]			[fix]
	clang-format:command = clang-format --style file -i			clang-format:command = clang-format --style file -i
	clang-format:pattern = (.c or .cc or **.h) and not "listfile:contrib/clang-format-ignorelist"			clang-format:pattern = (.c or .cc or **.h) and not "listfile:contrib/clang-format-ignorelist"

	rustfmt:command = rustfmt {rootpath}			rustfmt:command = rustfmt {rootpath}
	rustfmt:pattern = set:**.rs			rustfmt:pattern = set:**.rs

				# We use black, but currently with https://github.com/psf/black/pull/826 applied.
				# black:command = black --skip-string-normalization
				# black:pattern = set:.py - mercurial/thirdparty/ - "contrib/python-zstandard/**"