This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: make style-checker happy
ClosedPublic

Authored by ikostia on Sep 13 2017, 11:40 AM.

Download Raw Diff

Details

Reviewers

durham
ryanmce

Group Reviewers

Restricted Project

Commits

rFBHGX3c18346a2784: remotefilelog: make style-checker happy

Summary

test-check-code-hg.t complains about long lines here.

Test Plan

rt, make sure it does not complain anymore

Diff Detail

Repository

rFBHGX Facebook Mercurial Extensions

Branch

default

Lint

Lint OK

Unit

Unit Tests OK

Event Timeline

ikostia created this revision.Sep 13 2017, 11:40 AM

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2017, 11:40 AM

How did this get checked in with tests failing? :-(

This revision is now accepted and ready to land.Sep 13 2017, 11:41 AM

Sorry :( It was a quick follow up at Google's request and I apparently failed to run the whole suite on it.

I still <3 you @durham!

Closed by commit rFBHGX3c18346a2784: remotefilelog: make style-checker happy (authored by ikostia). · Explain WhySep 13 2017, 12:34 PM

This revision was automatically updated to reflect the committed changes.

shravyak updated this revision to Diff 1884.Sep 18 2017, 7:54 PM

Revision Contents
Changeset List

			Path	Packages
M			remotefilelog/__init__.py (6 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	1781		Sep 13 2017, 11:39 AM	★	★
Diff 2	1782	rFBHGX3c18346a2784722dd5f4af6af706801d117a767c	Sep 13 2017, 11:42 AM	★	★
Diff 3	1884		Sep 18 2017, 7:54 PM	★	★

Commit	Local	Parents	Author	Summary	Date
2eaac30206a5	3581	08844a0e90d9	Kostia Balytskyi	remotefilelog: make style-checker happy	Sep 13 2017, 11:36 AM

Diff 1781

remotefilelog/init.py

	packermap['02'] = (shallowbundle.shallowcg2packer,			packermap['02'] = (shallowbundle.shallowcg2packer,
	packermap02[1])			packermap02[1])
	if util.safehasattr(changegroup, '_addchangegroupfiles'):			if util.safehasattr(changegroup, '_addchangegroupfiles'):
	fn = '_addchangegroupfiles' # hg >= 3.6			fn = '_addchangegroupfiles' # hg >= 3.6
	else:			else:
	fn = 'addchangegroupfiles' # hg <= 3.5			fn = 'addchangegroupfiles' # hg <= 3.5
	wrapfunction(changegroup, fn, shallowbundle.addchangegroupfiles)			wrapfunction(changegroup, fn, shallowbundle.addchangegroupfiles)
	if util.safehasattr(changegroup, 'getchangegroup'):			if util.safehasattr(changegroup, 'getchangegroup'):
	wrapfunction(changegroup, 'getchangegroup', shallowbundle.getchangegroup)			wrapfunction(changegroup, 'getchangegroup',
				shallowbundle.getchangegroup)
	else:			else:
	wrapfunction(changegroup, 'makechangegroup', shallowbundle.makechangegroup)			wrapfunction(changegroup, 'makechangegroup',
				shallowbundle.makechangegroup)

	def storewrapper(orig, requirements, path, vfstype):			def storewrapper(orig, requirements, path, vfstype):
	s = orig(requirements, path, vfstype)			s = orig(requirements, path, vfstype)
	if shallowrepo.requirement in requirements:			if shallowrepo.requirement in requirements:
	s = shallowstore.wrapstore(s)			s = shallowstore.wrapstore(s)

	return s			return s
	wrapfunction(store, 'store', storewrapper)			wrapfunction(store, 'store', storewrapper)