Page MenuHomePhabricator

largefiles: avoid dynamically subclassing context instances
ClosedPublic

Authored by martinvonz on Oct 19 2019, 3:38 AM.

Details

Summary

E.g. copies.pathcopies() compares context objects for equality and
basectx.eq compares the type. But since largefiles was dynamically
creating classes, they would all be unequal. That led pathcopies(),
after some changes I made, to not short-circuit to get copy info only
from the dirstate. This patch fixes that short-circuiting (and other
places where context are being compared for equality).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.