This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7148

annotate: use unfiltered repo if we're annotating the working copy
AbandonedPublic

Authored by martinvonz on Oct 22 2019, 1:55 PM.

Details

Reviewers
durin42
marmoute
Group Reviewers
hg-reviewers
Summary

Same reasoning as in the previous patch. Speeds up `hg blame
mercurial/phases.py` from 0.365s to 0.304s.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 22 2019, 1:55 PM
marmoute added a subscriber: marmoute.Oct 22 2019, 5:41 PM

Do you have performance number for this ?

martinvonz edited the summary of this revision. (Show Details)Nov 12 2019, 4:32 PM
martinvonz updated this revision to Diff 18046.
durin42 accepted this revision.Nov 13 2019, 6:08 PM
This revision is now accepted and ready to land.Nov 13 2019, 6:08 PM
marmoute requested changes to this revision.Apr 22 2020, 11:59 AM

This was superseeded by another mechanism and can be safely abandonned.

This revision now requires changes to proceed.Apr 22 2020, 11:59 AM
martinvonz abandoned this revision.Apr 22 2020, 12:01 PM

I thought I already had abandoned this, but apparently not :)

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (5 lines)

Diff 18046

mercurial/commands.py

""" """
use_unfiltered = False use_unfiltered = False
if commandname == b'status': if commandname == b'status':
if not kwargs.get(b'rev') and not kwargs.get(b'change'): if not kwargs.get(b'rev') and not kwargs.get(b'change'):
use_unfiltered = True use_unfiltered = True
elif commandname == b'diff': elif commandname == b'diff':
if not kwargs.get(b'rev') and not kwargs.get(b'change'): if not kwargs.get(b'rev') and not kwargs.get(b'change'):
use_unfiltered = True use_unfiltered = True
elif commandname == b'annotate':
if not kwargs.get(b'rev'):
use_unfiltered = True
return repo.unfiltered() if use_unfiltered else repo return repo.unfiltered() if use_unfiltered else repo
# Commands start here, listed alphabetically # Commands start here, listed alphabetically
@command( @command(
if ( if (
linenumber linenumber
and (not opts.get(b'changeset')) and (not opts.get(b'changeset'))
and (not opts.get(b'number')) and (not opts.get(b'number'))
): ):
raise error.Abort(_(b'at least one of -n/-c is required for -l')) raise error.Abort(_(b'at least one of -n/-c is required for -l'))
rev = opts.get(b'rev') rev = opts.get(b'rev')
repo =_maybeunfilteredrepo(repo, b'annotate', pats, opts)
if rev: if rev:
repo = scmutil.unhidehashlikerevs(repo, [rev], b'nowarn') repo = scmutil.unhidehashlikerevs(repo, [rev], b'nowarn')
ctx = scmutil.revsingle(repo, rev) ctx = scmutil.revsingle(repo, rev)
ui.pager(b'annotate') ui.pager(b'annotate')
rootfm = ui.formatter(b'annotate', opts) rootfm = ui.formatter(b'annotate', opts)
if ui.debugflag: if ui.debugflag:
shorthex = pycompat.identity shorthex = pycompat.identity