This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7149

export: use unfiltered repo if we're exporting the working copy parent
AbandonedPublic

Authored by martinvonz on Oct 22 2019, 1:55 PM.

Details

Reviewers
durin42
marmoute
Group Reviewers
hg-reviewers
Summary

Same reasoning as in the previous patch. hg export drops from 0.180s
to 0.140s.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 22 2019, 1:55 PM
marmoute added a subscriber: marmoute.Oct 22 2019, 5:42 PM

Do you have performance number for this?

martinvonz edited the summary of this revision. (Show Details)Nov 12 2019, 4:32 PM
martinvonz updated this revision to Diff 18047.
durin42 accepted this revision.Nov 13 2019, 6:08 PM
This revision is now accepted and ready to land.Nov 13 2019, 6:08 PM
marmoute requested changes to this revision.Apr 22 2020, 11:59 AM

This was superseeded by another mechanism and can be safely abandonned.

This revision now requires changes to proceed.Apr 22 2020, 11:59 AM
martinvonz abandoned this revision.Apr 22 2020, 12:02 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (5 lines)

Diff 18047

mercurial/commands.py

if not kwargs.get(b'rev') and not kwargs.get(b'change'): if not kwargs.get(b'rev') and not kwargs.get(b'change'):
use_unfiltered = True use_unfiltered = True
elif commandname == b'diff': elif commandname == b'diff':
if not kwargs.get(b'rev') and not kwargs.get(b'change'): if not kwargs.get(b'rev') and not kwargs.get(b'change'):
use_unfiltered = True use_unfiltered = True
elif commandname == b'annotate': elif commandname == b'annotate':
if not kwargs.get(b'rev'): if not kwargs.get(b'rev'):
use_unfiltered = True use_unfiltered = True
elif commandname == b'export':
if not kwargs.get(b'bookmark') and not args:
use_unfiltered = True
return repo.unfiltered() if use_unfiltered else repo return repo.unfiltered() if use_unfiltered else repo
# Commands start here, listed alphabetically # Commands start here, listed alphabetically
@command( @command(
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
bookmark = opts.get(b'bookmark') bookmark = opts.get(b'bookmark')
changesets += tuple(opts.get(b'rev', [])) changesets += tuple(opts.get(b'rev', []))
if bookmark and changesets: if bookmark and changesets:
raise error.Abort(_(b"-r and -B are mutually exclusive")) raise error.Abort(_(b"-r and -B are mutually exclusive"))
repo =_maybeunfilteredrepo(repo, b'export', changesets, opts)
if bookmark: if bookmark:
if bookmark not in repo._bookmarks: if bookmark not in repo._bookmarks:
raise error.Abort(_(b"bookmark '%s' not found") % bookmark) raise error.Abort(_(b"bookmark '%s' not found") % bookmark)
revs = scmutil.bookmarkrevs(repo, bookmark) revs = scmutil.bookmarkrevs(repo, bookmark)
else: else:
if not changesets: if not changesets:
changesets = [b'.'] changesets = [b'.']